(meant for this to be posted on the list)
Having an unfoldAll() function seems like a reasonable solution. Is there
some way I can "officially" request such an addition?
Jared
On Wed, Feb 17, 2010 at 7:22 AM, Phil Thompson
<phil at riverbankcomputing.com>wrote:
> On Tue, 16 Feb 2010 03:50:22 -0500, Jared Sutton <jpsutton at gmail.com>
> wrote:
> > Hi All,
> >
> > For the last several years (spare time) I've been constructing a simple
> > cross-platform code editor called QSciTE using Qt4 version of
> Qscintilla2.
> > You can find it here, in case you're interested:
> >
> > http://qscite.googlecode.com/
> >
> > First off, thanks very much for making this library available to the
> public
> > under the GPL. It has some wonderful functionality built-in.
> >
> > I've been having some issues with code folding recently, which I believe
> to
> > have stemmed from at least one bug in Qscintilla. I have a simple menu
> > option to enable/disable code folding. Whenever I turn folding off, I
> want
> > any lines that are currently folded to be unfolded automatically, since
> it
> > doesn't make a whole lot of sense to have folded code that can't easily
> be
> > unfolded. Here's my toggleFolding() function which is directly connected
> > to
> > the menu option:
> >
> > void MainWindow::toggleFolding() {
> > QsciteEditor * doc = getCurDoc();
> > QsciteEditor::FoldStyle state =
> > static_cast<QsciteEditor::FoldStyle>((!doc->folding()) * 5);
> >
> > if (!state) {
> > // unfold all code before turning off folding
> > doc->foldAll(false);
> > }
> >
> > doc->setFolding(state);
> > }
> >
> > The QsciteEditor class is a child-class of Qscintilla, because I needed
> to
> > expose several functions for use with QtScript, and because I needed to
> > catch some key-presses that I needed to process specially. As you can
> see,
> > foldAll() is only getting called just before the folding is about to be
> > turned off. The documentation for foldAll() states "If any lines are
> > currently folded then they are all unfolded. Otherwise all lines are
> > folded." Now, my implementation does not take into account the
> possibility
> > that no lines were folded between the time that the folding was enabled
> and
> > disabled (which I'll expand on below), meaning that if foldAll() works as
> > documented, I should expect to see all lines get folded before the
> folding
> > is disabled. However, even when I fold one or more lines and then turn
> off
> > folding, I find that all lines are getting folded before folding gets
> > disabled. This seems like it's a problem with the foldAll()
> > implementation.
>> It depends...
>> foldAll() can only deal with what a particular lexer has set in the way of
> fold flags. I've found that lexers don't always exhibit consistent
> behaviour - some are just wrong.
>> Both Scite and QScintilla will call foldAll() (or the Scite equivalent)
> when you shift-control-click in the fold margin. I would compare the result
> of doing this in Scite with the same lexer set and the same file being
> edited. If the result is different then it's probably a QScintilla bug. If
> it's not then it's likely to be a Scintilla bug or feature (ie. in the
> particular lexer itself).
>> > This also brings up a few questions:
> > 1. Shouldn't setFolding() automatically unfold all lines that are
> currently
> > folded before the FoldStyle is set to NoFoldStyle? Does anyone expect to
> > have lines folded after they disable folding?
> > 2. If the person using QsciScintilla is expected to unfold all lines that
> > were folded before turning folding off, how can he know what lines are
> > folded? As far as I can tell, that information is private, as are the
> > functions/signals/slots that are responsible for changing a line's fold
> > state.
> >
> > So, I see these issues in the end:
> > 1. There appears to be a bug in the QsciScintilla:foldAll(bool) function.
> > It doesn't appear to function as documented.
> > 2. In my opinion, QsciScintilla::setFolding() should either unfold
> > everything when folding is turned off, or the appropriate member
> > variables/functions/signals/slots should be changed from private to
> > protected so that developers can deal with the situation without
> resorting
> > to hacking on Qscintilla directly.
>> How about an unfoldAll() method? (It's a shame that foldAll() was so badly
> named.) That would allow it to be used separately from setFolding(), and
> wouldn't change the behaviour of the latter for existing applications.
>> > For what it's worth, here's my development environment:
> > Arch Linux
> > KDEmod 4.4.0
> > Qscintilla 2.4.2
> > Qt 4.6.1
> >
> > Thanks for any insight you may have.
> >
> > Jared Sutton
>> Phil
>-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.riverbankcomputing.com/pipermail/qscintilla/attachments/20100217/959d2f7c/attachment.html>
More information about the QScintilla
mailing list
‘She has never mentioned her father to me. Was he—well, the sort of man whom the County Club would not have blackballed?’ "We walked by the side of our teams or behind the wagons, we slept on the ground at night, we did our own cooking, we washed our knives by sticking them into the ground rapidly a few times, and we washed our plates with sand and wisps of grass. When we stopped, we arranged our wagons in a circle, and thus formed a 'corral,' or yard, where we drove our oxen to yoke them up. And the corral was often very useful as a fort, or camp, for defending ourselves against the Indians. Do you see that little hollow down there?" he asked, pointing to a depression in the ground a short distance to the right of the train. "Well, in that hollow our wagon-train was kept three days and nights by the Indians. Three days and nights they stayed around, and made several attacks. Two of our men were killed and three were wounded by their arrows, and others had narrow escapes. One arrow hit me on the throat, but I was saved by the knot of my neckerchief, and the point only tore the skin a little. Since that time I have always had a fondness for large neckties. I don't know how many of the Indians we killed, as they carried off their dead and wounded, to save them from being scalped. Next to getting the scalps of their enemies, the most important thing with the Indians is to save their own. We had several fights during our journey, but that one was the worst. Once a little party of us were surrounded in a small 'wallow,' and had a tough time to defend ourselves successfully. Luckily for us, the Indians had no fire-arms then, and their bows and arrows were no match for our rifles. Nowadays they are well armed, but there are[Pg 41] not so many of them, and they are not inclined to trouble the railway trains. They used to do a great deal of mischief in the old times, and many a poor fellow has been killed by them." As dusk came on nearly the whole population of Maastricht, with all their temporary guests, formed an endless procession and went to invoke God's mercy by the Virgin Mary's intercession. They went to Our Lady's Church, in which stands the miraculous statue of Sancta Maria Stella Maris. The procession filled all the principal streets and squares of the town. I took my stand at the corner of the Vrijthof, where all marched past me, men, women, and children, all praying aloud, with loud voices beseeching: "Our Lady, Star of the Sea, pray for us ... pray for us ... pray for us ...!" It had not occurred to her for some hours after Mrs. Campbell had told her of Landor's death that she was free now to give herself to Cairness. She had gasped, indeed, when she did remember it, and had put the thought away, angrily and self-reproachfully. But it returned now, and she felt that she might cling to it. She had been grateful, and she had been faithful, too.[Pg 286] She remembered only that Landor had been kind to her, and forgot that for the last two years she had borne with much harsh coldness, and with a sort of contempt which she felt in her unanalyzing mind to have been entirely unmerited. Gradually she raised herself until she sat quite erect by the side of the mound, the old exultation of her half-wild girlhood shining in her face as she planned the future, which only a few minutes before had seemed so hopeless. After he had gloated over Sergeant Ramsey, Shorty got his men into the road ready to start. Si placed himself in front of the squad and deliberately loaded his musket in their sight. Shorty took his place in the rear, and gave out: The groups about each gun thinned out, as the shrieking fragments of shell mowed down man after man, but the rapidity of the fire did not slacken in the least. One of the Lieutenants turned and motioned with his saber to the riders seated on their horses in the line of limbers under the cover of the slope. One rider sprang from each team and ran up to take the place of men who had fallen. "As long as there's men and women in the world, the men 'ull be top and the women bottom." Then, in the house, the little girls were useful. Mrs. Backfield was not so energetic as she used to be. She had never been a robust woman, and though her husband's care had kept her well and strong, her frame was not equal to Reuben's demands; after fourteen years' hard labour, she suffered from rheumatism, which though seldom acute, was inclined to make her stiff and slow. It was here that Caro and Tilly came in, and Reuben began to appreciate his girls. After all, girls were needed in a house—and as for young men and marriage, their father could easily see that such follies did not spoil their usefulness or take them from him. Caro and Tilly helped their grandmother in all sorts of ways—they dusted, they watched pots, they shelled peas and peeled potatoes, they darned house-linen, they could even make a bed between them. HoME一级毛片视频免费公开
ENTER NUMBET 0018sourcewill.com.cn www.ttzhua.com.cn www.12xy.com.cn www.psoriasin.com.cn www.koyosha.com.cn www.dgzgsh.com.cn www.plumka.com.cn www.cwxd664.com.cn www.feeda.com.cn www.uvicsz.com.cn